[ 
https://issues.apache.org/jira/browse/HDFS-12486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16175231#comment-16175231
 ] 

Hanisha Koneru commented on HDFS-12486:
---------------------------------------

Thanks for the update, [~bharatviswa]. 
bq. The previous code patch is also using InetSocketAddress. I think it is okay 
here to continue with Util#getAddressesList and reuse the existing function.
You are right. Sorry I missed that.

Please remove the unused method _TestGetConf#getNamenodeId()_.

Other than that, patch v06 LGTM. The test failures are unrelated.

> GetConf to get journalnodeslist
> -------------------------------
>
>                 Key: HDFS-12486
>                 URL: https://issues.apache.org/jira/browse/HDFS-12486
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Bharat Viswanadham
>            Assignee: Bharat Viswanadham
>         Attachments: HDFS-12486.01.patch, HDFS-12486.02.patch, 
> HDFS-12486.03.patch, HDFS-12486.04.patch, HDFS-12486.05.patch, 
> HDFS-12486.06.patch
>
>
> GetConf command to list journal nodes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to