[
https://issues.apache.org/jira/browse/HDFS-12458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16183211#comment-16183211
]
Xiao Chen commented on HDFS-12458:
----------------------------------
Thanks for the review [~jojochuang].
Correct, strictly speaking waitClusterUp should happen after waitActive. (Or no
waitActive is needed at all, assuming safemode requires all DN up).
Updated the patch to call waitClusterUp after waitActive to remove confusion.
bq. why did you replace waitActive with waitClusterUp, rather than keeping
waitActive?
Because this is already done as part of the minicluster's restartNamenodes
method.
{code:title=MiniDFSCluster#restartNameNodes}
public synchronized void restartNameNodes() throws IOException {
for (int i = 0; i < namenodes.size(); i++) {
restartNameNode(i, false);
}
waitActive();
}
{code}
> TestReencryptionWithKMS fails regularly
> ---------------------------------------
>
> Key: HDFS-12458
> URL: https://issues.apache.org/jira/browse/HDFS-12458
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: encryption, test
> Affects Versions: 3.0.0-beta1
> Reporter: Konstantin Shvachko
> Assignee: Xiao Chen
> Attachments: HDFS-12458.01.patch, HDFS-12458.02.patch,
> HDFS-12458.03.patch
>
>
> {{TestReencryptionWithKMS}} fails pretty often on Jenkins. Should fix it.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
