[ 
https://issues.apache.org/jira/browse/HDFS-12467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16187456#comment-16187456
 ] 

Nandakumar commented on HDFS-12467:
-----------------------------------

Thanks [~vagarychen] for the detailed description. I agree with whatever you 
have said.

Previously there was no way to bring SCM out of startup chill mode with any API 
calls, it happened only through datanode registration. I used 
{{forceExitChillMode}} for this, now with forceExitChillMode() the system will 
come out of both the chill modes.

I would like to propose the following changes for chillMode (refactor the whole 
chill mode logic)

The following methods will be supported to manipulate chill mode status of SCM
* {{forceExitChillMode}} - will bring SCM out of chill mode (both startup and 
manual)
* {{enterChillMode}} - will set manual chill mode flag to true
* {{exitChillMode}} - will set manual chill mode flag to false
* {{getChillModeStatus}} - will return chill mode status string
* {{inChillMode}} - will return true if SCM is in chill mode, else false

The following methods will be removed
* {{clearChillModeFlag}}
* {{forceEnterChillMode}}
* {{isInManualChillMode}}
* {{isOutOfNodeChillMode}}

The getter and setter for MinimumChillModeNodes will remain as it is
* {{setMinimumChillModeNodes}}
* {{getMinimumChillModeNodes}}

This will make it easy to understand and use.

> Ozone: SCM: NodeManager should log when it comes out of chill mode
> ------------------------------------------------------------------
>
>                 Key: HDFS-12467
>                 URL: https://issues.apache.org/jira/browse/HDFS-12467
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>            Reporter: Nandakumar
>            Assignee: Nandakumar
>            Priority: Minor
>         Attachments: HDFS-12467-HDFS-7240.000.patch, 
> HDFS-12467-HDFS-7240.001.patch, HDFS-12467-HDFS-7240.002.patch, 
> HDFS-12467-HDFS-7240.003.patch, HDFS-12467-HDFS-7240.004.patch
>
>
> {{NodeManager}} should add a log message when it comes out of chill mode.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to