[
https://issues.apache.org/jira/browse/HDFS-12467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16183051#comment-16183051
]
Chen Liang commented on HDFS-12467:
-----------------------------------
Thanks for the remind [~anu]. Thanks [~nandakumar131] for the update. v002
patch LGTM, just noticed one more thing, sorry...
This check {{if(inStartupChillMode.get() && totalNodes.get() >=
chillModeNodeCount)}} would it be better to use {{getMinimumChillModeNodes()}}
instead of {{chillModeNodeCount}}? (like it is in current code). Although for
now they are effectively same thing, but if later we make change to
{{getMinimumChillModeNodes()}} for some reason and expect it will change chill
mode check, we may get unexpected behaviour.
> Ozone: SCM: NodeManager should log when it comes out of chill mode
> ------------------------------------------------------------------
>
> Key: HDFS-12467
> URL: https://issues.apache.org/jira/browse/HDFS-12467
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Reporter: Nandakumar
> Assignee: Nandakumar
> Priority: Minor
> Attachments: HDFS-12467-HDFS-7240.000.patch,
> HDFS-12467-HDFS-7240.001.patch, HDFS-12467-HDFS-7240.002.patch
>
>
> {{NodeManager}} should add a log message when it comes out of chill mode.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
