[
https://issues.apache.org/jira/browse/HDFS-12502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16190613#comment-16190613
]
Konstantin Shvachko commented on HDFS-12502:
--------------------------------------------
The change looks good. Few comments:
# There are white-space and unused import warnings, reported by Jenkins.
# You should probably JavaDoc new metric in {{TopMetrics}}.
# Should have a constant for {{"filesInGetListing"}}, rather than hardcoded.
# There is a potential NPE in {{FSN.getListing()}} since {{dl}} can be null.
# Do I understand correctly that {{"filesInGetListing"}} will be recorded even
if audit log is disabled? Which is probably not an expected behavior.
> nntop should support a category based on FilesInGetListingOps
> -------------------------------------------------------------
>
> Key: HDFS-12502
> URL: https://issues.apache.org/jira/browse/HDFS-12502
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: metrics
> Reporter: Zhe Zhang
> Assignee: Zhe Zhang
> Attachments: HDFS-12502.00.patch, HDFS-12502.01.patch
>
>
> Large listing ops can oftentimes be the main contributor to NameNode
> slowness. The aggregate cost of listing ops is proportional to the
> {{FilesInGetListingOps}} rather than the number of listing ops. Therefore
> it'd be very useful for nntop to support this category.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
