[
https://issues.apache.org/jira/browse/HDFS-12572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16198078#comment-16198078
]
Mukul Kumar Singh commented on HDFS-12572:
------------------------------------------
Thanks for the review [~xyao], please find my comments as following
LevelDBStore.java
Line 301-302: Please update javadoc to match with the behavior change
bq. done, changed this in MetadataStore.java as well
OzoneBucket.java
Line 534: we need to add a finally {} to ensure getRequest is closed properly.
bq. done
OzoneFileSystem.java
Line 188-196: is this optional or required for the Hadoop Compatible FS?
How do we handle path does not exist for parent and parent's parent?
E.g., client want to create /a/b/c/key1, only /a exist, both /a/b and /a/b/c
don't
exist.
bq. This is needed for contract test,
{{AbstractContractCreateTest#testCreateMakesParentDirs}}. This test assumes
that creating a file with non existent parent directory will create the
directory as well.
bq. because mkdirs is being called when the parent directory does not exists,
{{mkdirs}} will ensure that it will create all the non-existent parent
sub-directories as well, mkdir traverses up the path and creates all the
directories till one is found. So in the example, "/a/b" and "/a/b/c" will be
created.
Line 251: rename in KSM directly will be ideal.
bq. I agree, HDFS-11909 is raised for this issue, I have also added a TODO note
as well
Line 277: can you elaborate the overall rename semantics supported in java doc
with examples?
I think it might be easier to follow if we can categorize the cases based on
whether source/dst is
directlory or file like you did in mkdir().
bq. done
Line 310: NIT: we are actually checking dst's parent not dst dir
bq. done, comments updated
Line 378: How do we handle partial delete succeed when recursive is true?
bq. Thanks for catching this, when recursive is true, return value of
deleteObject will be ignored. This will ensure that the iterator will not stop
and will delete the remaining keys in the directory. I just checked
{{AliyunOSSFileSystem}} which also does something similar.
Line 439: NIT: returns true if directory exists or created successfully.
bq. done
Line 680: this can be removed as it does not provide more information than the
trace line at 678.
bq. done
> Ozone: OzoneFileSystem: delete/list status/rename/mkdir APIs
> ------------------------------------------------------------
>
> Key: HDFS-12572
> URL: https://issues.apache.org/jira/browse/HDFS-12572
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Affects Versions: HDFS-7240
> Reporter: Mukul Kumar Singh
> Assignee: Mukul Kumar Singh
> Labels: ozoneMerge
> Fix For: HDFS-7240
>
> Attachments: HDFS-12572-HDFS-7240.001.patch,
> HDFS-12572-HDFS-7240.002.patch, HDFS-12572-HDFS-7240.003.patch,
> HDFS-12572-HDFS-7240.004.patch, HDFS-12572-HDFS-7240.005.patch
>
>
> This jira will add the delete/list status/rename/mkdir APIs
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
