[
https://issues.apache.org/jira/browse/HDFS-12663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16208514#comment-16208514
]
Anu Engineer commented on HDFS-12663:
-------------------------------------
bq. As part of OzoneBucket#createKey we are currently exposing protobuf enums
OzoneProtos.ReplicationType and OzoneProtos.ReplicationFactor through client,
this can be replaced with client-side enums and conversion can be done
internally.
I am wondering why? Does the users or developers have any specific benefit from
this change ?
One small comment:
OzoneBucket.java:219: The default Replication Type and Replication Factor
should be read from the configs. You can always use a sane default like this.
> Ozone: OzoneClient: Remove protobuf classes exposed to clients through
> OzoneBucket
> ----------------------------------------------------------------------------------
>
> Key: HDFS-12663
> URL: https://issues.apache.org/jira/browse/HDFS-12663
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Reporter: Nanda kumar
> Assignee: Nanda kumar
> Labels: ozoneMerge
> Attachments: HDFS-12663-HDFS-7240.000.patch,
> HDFS-12663-HDFS-7240.001.patch
>
>
> As part of {{OzoneBucket#createKey}} we are currently exposing protobuf enums
> {{OzoneProtos.ReplicationType}} and {{OzoneProtos.ReplicationFactor}} through
> client, this can be replaced with client side enums and conversion can be
> done internally.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
