[
https://issues.apache.org/jira/browse/HDFS-12663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16209657#comment-16209657
]
Nanda kumar commented on HDFS-12663:
------------------------------------
Thanks for the review [~anu]
bq. I am wondering why? Does the users or developers have any specific benefit
from this change ?
There is no benefit as such, but implementation of {{ClientProtocol}} like
{{RestClient}} doesn't need to know about protobuf classes. Also as a user why
should they need to know/use {{OzoneProtos.ReplicationFactor}}. If we use it as
it's now, should we explain what {{OzoneProtos}} is to the user?
bq. OzoneBucket.java:219: The default Replication Type and Replication Factor
should be read from the configs. You can always use a sane default like this.
Good suggestion, will update the patch.
> Ozone: OzoneClient: Remove protobuf classes exposed to clients through
> OzoneBucket
> ----------------------------------------------------------------------------------
>
> Key: HDFS-12663
> URL: https://issues.apache.org/jira/browse/HDFS-12663
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Reporter: Nanda kumar
> Assignee: Nanda kumar
> Labels: ozoneMerge
> Attachments: HDFS-12663-HDFS-7240.000.patch,
> HDFS-12663-HDFS-7240.001.patch
>
>
> As part of {{OzoneBucket#createKey}} we are currently exposing protobuf enums
> {{OzoneProtos.ReplicationType}} and {{OzoneProtos.ReplicationFactor}} through
> client, this can be replaced with client side enums and conversion can be
> done internally.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
