[
https://issues.apache.org/jira/browse/HDFS-12396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rushabh S Shah updated HDFS-12396:
----------------------------------
Attachment: HDFS-12396.002.patch
Attached a new patch.
bq. In KMSUtil, I'm not fond of returning null when passed null
Null is not an invalid input. If EZ is not enabled, this will be null.
{quote}
The moved/new methods seem like they should be in KMSUtil, rather than
DFSUtilClient, with private/unstable annotations in case we need to make
further modifications.
{quote}
Added. After moving all the methods from {{hadoop-hdfs-client}} to
{{hadoop-common}}, I also needed to move {{UnknownCipherSuiteException.java}}
from {{hadoop-hdfs-project/hadoop-hdfs-client}} to
{{hadoop-common-project/hadoop-common}}. I think nothing should break.
{quote}
Minor, KeyProviderHelper is rather generic and doesn't convey what it does. I'd
consider something more like KeyProviderTokenAdapter, KeyProviderTokenIssuer,
etc.
{quote}
Addressed.
{quote}
Does WebHdfsFileSystem#keyProvider really need to exist and only be set for
tests? Could a spy be used instead?
{quote}
Addressed.
Please review.
> Webhdfs file system should get delegation token from kms provider.
> ------------------------------------------------------------------
>
> Key: HDFS-12396
> URL: https://issues.apache.org/jira/browse/HDFS-12396
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: encryption, kms, webhdfs
> Reporter: Rushabh S Shah
> Assignee: Rushabh S Shah
> Attachments: HDFS-12396.001.patch, HDFS-12396.002.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
