[
https://issues.apache.org/jira/browse/HDFS-12521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16218005#comment-16218005
]
Xiaoyu Yao commented on HDFS-12521:
-----------------------------------
Thanks [~ljain] for working on this. The patch v5 looks good to me overall.
Here are a few comments:
ContainerStateManager.java
Line 41: NIT: please expand the collapsed imports
Line 208: we need to load the allocated usage here.
ContainerInfo needs to include allocated usage that information HDFS-12474 will
add that.
Line 405: good catch and fix.
Line 428: NIT: suggest rename to getMatchingContainers and return
List<BlockContainerInfo>
Line 431: I think readlock is good enough.
StorageContainerLocationProtocol.proto
Line 83: NIT: containers
TestContainerStateManager
Line 43-48: we spin up the test cluster and the initialize the
xceiverClientManager.
Please add a @After routine to tear down the resources to avoid resource leak.
Line 53-55: this local variables can be refactored into class private members
are they can be
reused in many tests.
ScmClient.java
Line 48: do we want to change ScmClient#createContainer to return a
containerInfo instead of pipeline as well?
ContainerOperationClient.java
Line 85: same as above.
> Ozone: SCM should read all Container info into memory when booting up
> ---------------------------------------------------------------------
>
> Key: HDFS-12521
> URL: https://issues.apache.org/jira/browse/HDFS-12521
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Reporter: Anu Engineer
> Assignee: Lokesh Jain
> Labels: ozoneMerge
> Attachments: HDFS-12521-HDFS-7240.001.patch,
> HDFS-12521-HDFS-7240.002.patch, HDFS-12521-HDFS-7240.003.patch,
> HDFS-12521-HDFS-7240.004.patch, HDFS-12521-HDFS-7240.005.patch
>
>
> When SCM boots up it should read all containers into memory. This is a
> performance optimization that allows delays on SCM side. This JIRA tracks
> that issue.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
