[
https://issues.apache.org/jira/browse/HDFS-12582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16222748#comment-16222748
]
Bharat Viswanadham commented on HDFS-12582:
-------------------------------------------
Thanks Chris, for rebasing the patch.
One minor comment
1. we can skip calling builder methods, if we are passing default values.
Example: isDir(false) or symlink(null)
> Replace HdfsFileStatus constructor with a builder pattern.
> ----------------------------------------------------------
>
> Key: HDFS-12582
> URL: https://issues.apache.org/jira/browse/HDFS-12582
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Bharat Viswanadham
> Assignee: Bharat Viswanadham
> Attachments: HDFS-12582.01.patch, HDFS-12582.02.patch,
> HDFS-12582.03.patch, HDFS-12582.04.patch, HDFS-12582.05.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
