[ 
https://issues.apache.org/jira/browse/HDFS-12582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16222885#comment-16222885
 ] 

Bharat Viswanadham commented on HDFS-12582:
-------------------------------------------

[~chris.douglas]
Thanks for addressing.

*In TestFsck.java*
storagePolicy(HdfsConstants.BLOCK_STORAGE_POLICY_ID_UNSPECIFIED)

The default value for storage policy is 
HdfsConstants.BLOCK_STORAGE_POLICY_ID_UNSPECIFIED. One place it is missing :) 
I think here it is okay, as this is not normal default value, which is a 
default value which we have assigned in builder.

+1 from me.

> Replace HdfsFileStatus constructor with a builder pattern.
> ----------------------------------------------------------
>
>                 Key: HDFS-12582
>                 URL: https://issues.apache.org/jira/browse/HDFS-12582
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Bharat Viswanadham
>            Assignee: Bharat Viswanadham
>         Attachments: HDFS-12582.01.patch, HDFS-12582.02.patch, 
> HDFS-12582.03.patch, HDFS-12582.04.patch, HDFS-12582.05.patch, 
> HDFS-12582.06.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to