[
https://issues.apache.org/jira/browse/HDFS-12739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16242465#comment-16242465
]
Mukul Kumar Singh commented on HDFS-12739:
------------------------------------------
Thanks for the updated patch [~shashikant], the latest patch looks really good.
Some comments
1) I tried deploying this on a cluster and the help/usage information is being
being printed anyhow. These command operations are hidden.
2) Need to add a test where an existing scm server is initialized and the
server is re-initialized
3) StorageContainerManager:java:207, the help needs to be formatted properly
4) StorageContainerManager:java:368, Lets create a new OzoneConfiguration
object here and pass the same to createSCM
5) StorageContainerManager:java:407: Please add cases for "clusterid" and
"regular" and then lets use the default case to handle invalid options and
print usage. I feel we should add a help option as well.
6) StorageContainerManager:java:440: This error message should be changed to
something like "cluster already initialized" and then append the current
message.
7) Please fix the checkstyle issues as well
> Add Support for SCM --init command
> ----------------------------------
>
> Key: HDFS-12739
> URL: https://issues.apache.org/jira/browse/HDFS-12739
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: HDFS-7240
> Affects Versions: HDFS-7240
> Reporter: Shashikant Banerjee
> Assignee: Shashikant Banerjee
> Attachments: HDFS-12739-HDFS-7240.001.patch,
> HDFS-12739-HDFS-7240.002.patch, HDFS-12739-HDFS-7240.003.patch,
> HDFS-12739-HDFS-7240.004.patch, HDFS-12739-HDFS-7240.005.patch,
> HDFS-12739-HDFS-7240.006.patch, HDFS-12739-HDFS-7240.007.patch
>
>
> SCM --init command will generate cluster ID and persist it locally. The same
> cluster Id will be shared with KSM and the datanodes. IF the cluster Id is
> already available in the locally available version file, it will just read
> the cluster Id .
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
