[
https://issues.apache.org/jira/browse/HDFS-12739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16243778#comment-16243778
]
Mukul Kumar Singh commented on HDFS-12739:
------------------------------------------
Thanks for the updated patch [~shashikant], the latest patch is almost ready.
Some very small minor comments. Rest Looks good to me after these changes are
done.
1) Storage.java: Please change the logging to sl4j in place to apache.commons.
2) Storage.java:106, extra space between long and getCreationTime
3) StorageContainerManager:396, set the exit code before returning
4) StorageInfo.java: Please change the logging to sl4j in place to
apache.commons.
5) readFrom, can use try with resources block as in the write function
> Add Support for SCM --init command
> ----------------------------------
>
> Key: HDFS-12739
> URL: https://issues.apache.org/jira/browse/HDFS-12739
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: HDFS-7240
> Affects Versions: HDFS-7240
> Reporter: Shashikant Banerjee
> Assignee: Shashikant Banerjee
> Attachments: HDFS-12739-HDFS-7240.001.patch,
> HDFS-12739-HDFS-7240.002.patch, HDFS-12739-HDFS-7240.003.patch,
> HDFS-12739-HDFS-7240.004.patch, HDFS-12739-HDFS-7240.005.patch,
> HDFS-12739-HDFS-7240.006.patch, HDFS-12739-HDFS-7240.007.patch,
> HDFS-12739-HDFS-7240.008.patch
>
>
> SCM --init command will generate cluster ID and persist it locally. The same
> cluster Id will be shared with KSM and the datanodes. IF the cluster Id is
> already available in the locally available version file, it will just read
> the cluster Id .
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
