[
https://issues.apache.org/jira/browse/HDFS-12794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247382#comment-16247382
]
Mukul Kumar Singh commented on HDFS-12794:
------------------------------------------
Thanks for the patch Shashikant,
1) ChunkGroupOutputStream:75: this can be changed to ArrayBlockingQueue
2) ChunkGroupOutputStream:109, lets change this name to maxQueueSize, and also
at all the other places
3) ChunkGroupOutputStream:290, this check should be moved before the start of
this if statement.
4) ChunkGroupOutputStream: 417, queue here cannot be null, any reason for doing
this ?
5) ChunkOutputStream:64,65 are not being used, Please remove them
6) ChunkOutputStream:247 & 248 can be changed to
Preconditions.checkNotNull(queue.remove(reply.getTraceID()). Also do we need a
return true here ?
7) In then apply the response should be validated using
{{validateContainerResponse(response);}} as in
ContainerProtocolCalls#writeChunk, Also if we can just keep the formatting as
in the writeChunk command. Would it also make sense for writeChunk to use
WriteChunkAsync with get on the future?
> Ozone: Parallelize ChunkOutputSream Writes to container
> -------------------------------------------------------
>
> Key: HDFS-12794
> URL: https://issues.apache.org/jira/browse/HDFS-12794
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Affects Versions: HDFS-7240
> Reporter: Shashikant Banerjee
> Assignee: Shashikant Banerjee
> Fix For: HDFS-7240
>
> Attachments: HDFS-12794-HDFS-7240.001.patch
>
>
> The chunkOutPutStream Write are sync in nature .Once one chunk of data gets
> written, the next chunk write is blocked until the previous chunk is written
> to the container.
> The ChunkOutputWrite Stream writes should be made async and Close on the
> OutputStream should ensure flushing of all dirty buffers to the container.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
