[
https://issues.apache.org/jira/browse/HDFS-12754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254287#comment-16254287
]
Xiao Chen commented on HDFS-12754:
----------------------------------
Nothing missing. :) I just wanted to share my understanding from the patch, to
make sure I understands the problem / fix correctly, and perhaps help future
readers.
The checkstyle error is complaining because we changed the variable name. It
won't complain about a constant var (all upper case) not being private. Now
that it's (reasonably) no longer a {{final}} constant var, it gets this warning.
{code}
- static final long LEASE_RENEWER_GRACE_DEFAULT = 60*1000L;
+ static long leaseRenewerGraceDefault = 60*1000L;
{code}
Can we just make leaseRenewerGraceDefault private? It's not used outside of the
class.
Thanks.
> Lease renewal can hit a deadlock
> ---------------------------------
>
> Key: HDFS-12754
> URL: https://issues.apache.org/jira/browse/HDFS-12754
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 2.8.1
> Reporter: Kuhu Shukla
> Assignee: Kuhu Shukla
> Attachments: HDFS-12754.001.patch, HDFS-12754.002.patch,
> HDFS-12754.003.patch, HDFS-12754.004.patch, HDFS-12754.005.patch,
> HDFS-12754.006.patch, HDFS-12754.007.patch
>
>
> The Client and the renewer can hit a deadlock during close operation since
> closeFile() reaches back to the DFSClient#removeFileBeingWritten. This is
> possible if the client class close when the renewer is renewing a lease.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
