[
https://issues.apache.org/jira/browse/HDFS-12754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16262025#comment-16262025
]
Xiao Chen commented on HDFS-12754:
----------------------------------
Thanks Kuhu for revving and Kihwal for triggering pre-commit.
- The method naming and test timeout bump from [my above
comment|https://issues.apache.org/jira/browse/HDFS-12754?focusedCommentId=16252760&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16252760]
seems unaddressed. I know this sounds very minor, but let's try our best to
make tests stable. This way, pre-commit will less likely to have false
positives, which benefits everybody.
- {{LeaseRenewer#getLeaseRenewerGraceDefault}} is not used. Suggest not to add
it in this patch.
Otherwise +1.
> Lease renewal can hit a deadlock
> ---------------------------------
>
> Key: HDFS-12754
> URL: https://issues.apache.org/jira/browse/HDFS-12754
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 2.8.1
> Reporter: Kuhu Shukla
> Assignee: Kuhu Shukla
> Attachments: HDFS-12754.001.patch, HDFS-12754.002.patch,
> HDFS-12754.003.patch, HDFS-12754.004.patch, HDFS-12754.005.patch,
> HDFS-12754.006.patch, HDFS-12754.007.patch, HDFS-12754.008.patch
>
>
> The Client and the renewer can hit a deadlock during close operation since
> closeFile() reaches back to the DFSClient#removeFileBeingWritten. This is
> possible if the client class close when the renewer is renewing a lease.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
