[
https://issues.apache.org/jira/browse/HDFS-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13046081#comment-13046081
]
Suresh Srinivas commented on HDFS-2030:
---------------------------------------
# TestFSImageUpgrade
#* is missing banner.
#* Should we just put this in one of the existing tests?
#* Why do you need null and empty check in the tests if you are testing for
startsWith("CID")
#* Do we need a test to check block pool ID is set?
#* Instead of assertTrue, use assertEquals where possible.
#* Please split the tests into testUpgradeFrom204, testUpgradeFrom22 and
testUpgradeCurrentRelease. Also this test does not really do upgrade. Should we
rename the test method.
#* There are few lines repeated every where. You could move it into a separate
method.
# FSImage.java
#* Is it better to to have two methods setBlockPoolID() and setClusterID()?
#* "Try to set the clusterid and blockpoolid for the upgrade." Why Try to?
#* It is better to add the description in comments of what is happening in one
place instead of spread all over. You may also want to move startOpt ==
StartupOption.UPGRADE into trySetClusterIDAndBlockPoolID().
> Fix the usability of namenode upgrade command
> ---------------------------------------------
>
> Key: HDFS-2030
> URL: https://issues.apache.org/jira/browse/HDFS-2030
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.23.0
> Reporter: Bharath Mundlapudi
> Assignee: Bharath Mundlapudi
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: HDFS-2030-1.patch
>
>
> Fixing the Namenode upgrade option along the same line as Namenode format
> option.
> If clusterid is not given then clusterid will be automatically generated for
> the upgrade but if clusterid is given then it will be honored.
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
