[
https://issues.apache.org/jira/browse/HDFS-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13046800#comment-13046800
]
Bharath Mundlapudi commented on HDFS-2030:
------------------------------------------
Thanks for the review, Suresh.
My comments inline.
1.1 Missing banner - done.
1.2 This method is package protected, this unit test just test this function
instead of using time consuming MiniDFSCluster.
1.3 Removed the null and empty checks.
1.4 BoolpoolID is autogenerated. Now i have modified the tests to not mock
this.
1.5 Added assertEquals where necessary
1.6 Made multiple tests
2.1 Since the setBlockPoolID() and setClusterID() are in NNStorage, i moved
this function to this class now solves this problem.
2.2 renamed the function
2.3 comments moved outside the function and moved the if condition inside the
method.
Attaching the patch with these changes.
> Fix the usability of namenode upgrade command
> ---------------------------------------------
>
> Key: HDFS-2030
> URL: https://issues.apache.org/jira/browse/HDFS-2030
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.23.0
> Reporter: Bharath Mundlapudi
> Assignee: Bharath Mundlapudi
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: HDFS-2030-1.patch
>
>
> Fixing the Namenode upgrade option along the same line as Namenode format
> option.
> If clusterid is not given then clusterid will be automatically generated for
> the upgrade but if clusterid is given then it will be honored.
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
