[ https://issues.apache.org/jira/browse/HDFS-12741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16296543#comment-16296543 ]
Nanda kumar commented on HDFS-12741: ------------------------------------ Thanks for updating [~shashikant], the patch is almost ready. Some very minor NITs. KeySpaceManager line:278 javadoc - {{constructs}} should be {{Constructs}} (caps 'C'). {{instance}} is misspelled. line:312 javadoc - {{instance}} is misspelled. line:337 {{"KSM initialization succeeded." + "Current cluster id for sd="}} can be changed to {{"KSM initialization succeeded. Current cluster id for sd="}} line:347 {{"KSM already initialized. Reusing existing" + " cluster id for sd="}} can be changed to {{"KSM already initialized. Reusing existing cluster id for sd="}} line:355 javadoc - {{parses}} to {{Parses}} line:357 {{StartupOption}} is misspelled. line:365 We don't have to handle {{IllegalArgumentException}}, {{StartupOption#parse}} will never throw {{IllegalArgumentException}}. > ADD support for KSM --createObjectStore command > ----------------------------------------------- > > Key: HDFS-12741 > URL: https://issues.apache.org/jira/browse/HDFS-12741 > Project: Hadoop HDFS > Issue Type: Sub-task > Affects Versions: HDFS-7240 > Reporter: Shashikant Banerjee > Assignee: Shashikant Banerjee > Fix For: HDFS-7240 > > Attachments: HDFS-12741-HDFS-7240.001.patch, > HDFS-12741-HDFS-7240.002.patch, HDFS-12741-HDFS-7240.003.patch, > HDFS-12741-HDFS-7240.004.patch, HDFS-12741-HDFS-7240.005.patch, > HDFS-12741-HDFS-7240.006.patch, HDFS-12741-HDFS-7240.007.patch, > HDFS-12741-HDFS-7240.008.patch > > > KSM --createObjectStore command reads the ozone configuration information and > creates the KSM version file and reads the SCM version file from the SCM > specified. > > The SCM version file is stored in the KSM metadata directory and before > communicating with an SCM KSM verifies that it is communicating with an SCM > where the relationship has been established via createObjectStore command. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org