[ https://issues.apache.org/jira/browse/HDFS-12942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16300648#comment-16300648 ]
Arpit Agarwal commented on HDFS-12942: -------------------------------------- The v3 patch looks good to me. Very minor comment on the unit test {{testMoveBlockFailure}}. The following log message should say testMoveBlockFailure. {code} } catch (Exception ex) { LOG.info("Exception in testMoveBlockSuccess ", ex); {code} +1 otherwise. > Synchronization issue in FSDataSetImpl#moveBlock > ------------------------------------------------ > > Key: HDFS-12942 > URL: https://issues.apache.org/jira/browse/HDFS-12942 > Project: Hadoop HDFS > Issue Type: Bug > Reporter: Ajay Kumar > Assignee: Ajay Kumar > Attachments: HDFS-12942.001.patch, HDFS-12942.002.patch, > HDFS-12942.003.patch > > > FSDataSetImpl#moveBlock works in following following 3 steps: > # first creates a new replicaInfo object > # calls finalizeReplica to finalize it. > # Calls removeOldReplica to remove oldReplica. > A client can potentially append to the old replica between step 1 and 2. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org