[
https://issues.apache.org/jira/browse/HDFS-12942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16340102#comment-16340102
]
Virajith Jalaparti commented on HDFS-12942:
-------------------------------------------
Thanks for the updated patch [~ajayydv]. A couple of issues with patch v5 that
are causing the failed tests.
{code:java}
+ FsVolumeImpl volume = (FsVolumeImpl) newReplicaInfo.getVolume();
+ volume.incDfsUsedAndNumBlocks(bpid, newReplicaInfo.getBytesOnDisk())
{code}
This shouldn't be added to {{finalizeReplica}}. This should be called in
{{finalizeNewReplica}} if {{finalizeReplica}} succeeds.
Also, after the deletions in the catch block in {{finalizeNewReplica}}, the
exception has to be re-thrown.
> Synchronization issue in FSDataSetImpl#moveBlock
> ------------------------------------------------
>
> Key: HDFS-12942
> URL: https://issues.apache.org/jira/browse/HDFS-12942
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Ajay Kumar
> Assignee: Ajay Kumar
> Priority: Major
> Attachments: HDFS-12942.001.patch, HDFS-12942.002.patch,
> HDFS-12942.003.patch, HDFS-12942.004.patch, HDFS-12942.005.patch
>
>
> FSDataSetImpl#moveBlock works in following following 3 steps:
> # first creates a new replicaInfo object
> # calls finalizeReplica to finalize it.
> # Calls removeOldReplica to remove oldReplica.
> A client can potentially append to the old replica between step 1 and 2.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
