[
https://issues.apache.org/jira/browse/HDFS-12974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16312594#comment-16312594
]
Xiao Chen commented on HDFS-12974:
----------------------------------
Thanks for the new rev [~zhenyi]. Looks pretty good to me.
Also verified the test passed with the fix, failed without.
I think we can improve the test a little:
- Use a string constant for the {{AuthorizationException}} message, and reuse
it during {{assertExceptionContains}}.
- After catching IOException, we can first assert it's a {{RemoteException}}.
Then {{unwrapRemoteException}}, and verify the inner exception type is the
AuthorizationException.
- Nit: {{public void ensureKeyIsInitialized() throws IOException { }}} should
remove space between brackets to follow existing style.
+1 from me once these are done.
> Exception information can not be returned when I create transparent
> encryption zone.
> ------------------------------------------------------------------------------------
>
> Key: HDFS-12974
> URL: https://issues.apache.org/jira/browse/HDFS-12974
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: encryption
> Affects Versions: 3.0.0
> Reporter: fang zhenyi
> Assignee: fang zhenyi
> Priority: Minor
> Attachments: HDFS-12974.001.patch, HDFS-12974.002.patch,
> HDFS-12974.003.patch, HDFS-12974.004.patch
>
>
> When I add the following configuration to the kms-acl.xml file, I create
> encrypted space and I can not get any exception information.
> <property>
> <name>key.acl.key2.GENERATE_EEK</name>
> <value>mr</value>
> </property>
> root@fangzhenyi01:~# hdfs crypto -createZone -keyName key2 -path /zone
> 2018-01-02 10:41:44,632 WARN util.NativeCodeLoader: Unable to load
> native-hadoop library for your platform... using builtin-java classes where
> applicable
> RemoteException:
> root@fangzhenyi01:~#
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
