[
https://issues.apache.org/jira/browse/HDFS-12919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16318177#comment-16318177
]
Yiqun Lin commented on HDFS-12919:
----------------------------------
I'm not so familiar with HDFS Erasure coding. Just some minor comments for the
unit tests:
{{TestRouterRpc.java}}
# can we create a log instance to print detail info instead of using system out?
# If these lines are not needed, just remove them
{noformat}
/*
+ assertEquals(1, response.length);
+ assertTrue(response[0].isSucceed());
+ */
{noformat}
# Following line seems incorrect.
{code}
+ // Remove the policy and check the one for the test folder
+ routerProtocol.removeErasureCodingPolicy(newPolicyName);
+ ErasureCodingPolicy policyRouter3 =
+ routerProtocol.getErasureCodingPolicy(dirPath);
+ assertEquals(newPolicyName, policyRouter3.getName());
+ ErasureCodingPolicy policyNamenode3 =
+ routerProtocol.getErasureCodingPolicy(dirPath); <---- should use
nnProtocol to get
+ assertEquals(newPolicyName, policyNamenode3.getName());
{code}
> RBF: Support erasure coding methods in RouterRpcServer
> ------------------------------------------------------
>
> Key: HDFS-12919
> URL: https://issues.apache.org/jira/browse/HDFS-12919
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: 3.0.0
> Reporter: Íñigo Goiri
> Assignee: Íñigo Goiri
> Priority: Critical
> Labels: RBF
> Attachments: HDFS-12919.000.patch, HDFS-12919.001.patch,
> HDFS-12919.002.patch, HDFS-12919.003.patch, HDFS-12919.004.patch,
> HDFS-12919.005.patch, HDFS-12919.006.patch, HDFS-12919.007.patch,
> HDFS-12919.008.patch, HDFS-12919.009.patch, HDFS-12919.010.patch,
> HDFS-12919.011.patch, HDFS-12919.012.patch, HDFS-12919.013.patch
>
>
> MAPREDUCE-6954 started to tune the erasure coding settings for staging files.
> However, the {{Router}} does not support this operation and throws:
> {code}
> 17/12/12 14:36:07 INFO mapreduce.JobSubmitter: Cleaning up the staging area
> /tmp/hadoop-yarn/staging/hadoop/.staging/job_1513116010218_0002
> org.apache.hadoop.ipc.RemoteException(java.lang.UnsupportedOperationException):
> Operation "setErasureCodingPolicy" is not supported
> at
> org.apache.hadoop.hdfs.server.federation.router.RouterRpcServer.checkOperation(RouterRpcServer.java:368)
> at
> org.apache.hadoop.hdfs.server.federation.router.RouterRpcServer.setErasureCodingPolicy(RouterRpcServer.java:1805)
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
