[ 
https://issues.apache.org/jira/browse/HDFS-12574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16328990#comment-16328990
 ] 

Rushabh S Shah commented on HDFS-12574:
---------------------------------------

Based on offline discussions with [~daryn], he had following suggestions.

+WebHdfsFileSystem.java+
 # Replace \{{redirectUrl}} with \{{resolvedUrl}}.

+EncryptableInputStream.java+
 # Remove this class altogether.

+DFSCient.java+
 # Move \{{DFSInputStream#createWrappedInputStream}} to {{DFSClient}}

+NamenodeWebHdfsMethods.java+
 # Previous patch was not applying cleanly due to some change. Rebased the 
patch.

Addressed all the comments in the latest patch.

Unit Test Failures.
{noformat}
[INFO] Running org.apache.hadoop.hdfs.server.balancer.TestBalancer
[INFO] Tests run: 32, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 382.018 
s - in org.apache.hadoop.hdfs.server.balancer.TestBalancer
[INFO] Running org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
[ERROR] Tests run: 10, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 
116.024 s <<< FAILURE! - in 
org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
[ERROR] 
testUnderReplicationAfterVolFailure(org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure)
 Time elapsed: 93.742 s <<< ERROR!
java.util.concurrent.TimeoutException: ----------> tracked by HDFS-11398
[WARNING] Tests run: 18, Failures: 0, Errors: 0, Skipped: 2, Time elapsed: 
267.471 s - in org.apache.hadoop.hdfs.TestDFSStripedOutputStreamWithFailure090
[INFO] Running org.apache.hadoop.hdfs.TestDFSStripedOutputStreamWithFailure110
[WARNING] Tests run: 18, Failures: 0, Errors: 0, Skipped: 2, Time elapsed: 
263.43 s - in org.apache.hadoop.hdfs.TestDFSStripedOutputStreamWithFailure110
[INFO] Running org.apache.hadoop.hdfs.TestDFSStripedOutputStreamWithFailure140
[WARNING] Tests run: 18, Failures: 0, Errors: 0, Skipped: 2, Time elapsed: 
267.398 s - in org.apache.hadoop.hdfs.TestDFSStripedOutputStreamWithFailure140
[INFO] Running org.apache.hadoop.hdfs.TestDFSStripedOutputStreamWithFailure150
[WARNING] Tests run: 18, Failures: 0, Errors: 0, Skipped: 2, Time elapsed: 
266.834 s - in org.apache.hadoop.hdfs.TestDFSStripedOutputStreamWithFailure150
[INFO] Running org.apache.hadoop.hdfs.TestDFSStripedOutputStreamWithFailure180
[WARNING] Tests run: 18, Failures: 0, Errors: 0, Skipped: 2, Time elapsed: 
265.416 s - in org.apache.hadoop.hdfs.TestDFSStripedOutputStreamWithFailure180
[INFO] Running org.apache.hadoop.hdfs.TestDFSStripedOutputStreamWithFailure190 
[INFO] Running 
org.apache.hadoop.hdfs.TestDFSStripedOutputStreamWithFailureWithRandomECPolicy
[WARNING] Tests run: 18, Failures: 0, Errors: 0, Skipped: 12, Time elapsed: 
243.934 s - in 
org.apache.hadoop.hdfs.TestDFSStripedOutputStreamWithFailureWithRandomECPolicy
[INFO] Running org.apache.hadoop.hdfs.TestErasureCodingPolicies
[INFO] Tests run: 19, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 119.921 
s - in org.apache.hadoop.hdfs.TestErasureCodingPolicies
[INFO] Running org.apache.hadoop.hdfs.TestMaintenanceState
[INFO] Tests run: 25, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 374.135 
s - in org.apache.hadoop.hdfs.TestMaintenanceState
[INFO] Running org.apache.hadoop.hdfs.TestReplication
[INFO] Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 53.958 s 
- in org.apache.hadoop.hdfs.TestReplication
[INFO] Running org.apache.hadoop.hdfs.web.TestWebHdfsTimeouts
[INFO] Tests run: 16, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.164 s 
- in org.apache.hadoop.hdfs.web.TestWebHdfsTimeouts
[ERROR] Errors: 
[ERROR] TestDataNodeVolumeFailure.testUnderReplicationAfterVolFailure:412 » 
Timeout Ti...
[INFO] 
[ERROR] Tests run: 391, Failures: 0, Errors: 1, Skipped: 42{noformat}
Re-ran all the failed tests to ensure none of them is failing due to my change.

All were passing except 
{{TestDataNodeVolumeFailure#testUnderReplicationAfterVolFailure}} which is 
being tracked by  {{HDFS-11398}}.
[~daryn]: can you please provide feedback on the latest patch.


> Add CryptoInputStream to WebHdfsFileSystem read call.
> -----------------------------------------------------
>
>                 Key: HDFS-12574
>                 URL: https://issues.apache.org/jira/browse/HDFS-12574
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: encryption, kms, webhdfs
>            Reporter: Rushabh S Shah
>            Assignee: Rushabh S Shah
>            Priority: Major
>         Attachments: HDFS-12574.001.patch, HDFS-12574.002.patch, 
> HDFS-12574.003.patch, HDFS-12574.004.patch, HDFS-12574.005.patch, 
> HDFS-12574.006.patch, HDFS-12574.007.patch, HDFS-12574.008.patch, 
> HDFS-12574.009.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to