[
https://issues.apache.org/jira/browse/HDFS-12574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16342005#comment-16342005
]
Xiao Chen commented on HDFS-12574:
----------------------------------
Thanks for the work here Rushabh and Daryn. I followed the comments and looked
at the patch, latest patch looks pretty elegant! Tests LGTM too, looks thorough
and covered compatibilities.
Some really minor comments:
* I think {{verifyStreamsDifferent}} can use the non-webhdfs DFS.open to read
from /.raw, and verify that it's the same when reading raw from webhdfs
* WebHdfsFileSystem$WebHdfsInputStream: the 2 new methods can be package
private
* parameters of {{getRedirectedUrl}} is unused.
* minor typo s/becuase/because/g in comment at line 2043
> Add CryptoInputStream to WebHdfsFileSystem read call.
> -----------------------------------------------------
>
> Key: HDFS-12574
> URL: https://issues.apache.org/jira/browse/HDFS-12574
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: encryption, kms, webhdfs
> Reporter: Rushabh S Shah
> Assignee: Rushabh S Shah
> Priority: Major
> Attachments: HDFS-12574.001.patch, HDFS-12574.002.patch,
> HDFS-12574.003.patch, HDFS-12574.004.patch, HDFS-12574.005.patch,
> HDFS-12574.006.patch, HDFS-12574.007.patch, HDFS-12574.008.patch,
> HDFS-12574.009.patch, HDFS-12574.010.branch-2.8.patch,
> HDFS-12574.010.branch-2.patch, HDFS-12574.010.patch,
> HDFS-12574.011.branch-2.8.patch, HDFS-12574.011.branch-2.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
