[
https://issues.apache.org/jira/browse/HDFS-12997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16340276#comment-16340276
]
Xiaoyu Yao commented on HDFS-12997:
-----------------------------------
Thanks [~ajayydv] for working on this. Patch v3 looks good to me overall. Just
few minor issues. +1 after that.
DataStorage.java
Line 936: this change does not correctly match the parameters. Please check and
fix.
Storage.java
Line 1334: if (LOG.isDebugEnabled()) can be removed with slf4j as long as the
number of parameters is less than 4 and there is no function call to get the
value of the parameter. More details can be found here:
https://www.slf4j.org/faq.html#logging_performance
> Move logging to slf4j in BlockPoolSliceStorage and Storage
> -----------------------------------------------------------
>
> Key: HDFS-12997
> URL: https://issues.apache.org/jira/browse/HDFS-12997
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Ajay Kumar
> Assignee: Ajay Kumar
> Priority: Major
> Attachments: HDFS-12997.001.patch, HDFS-12997.002.patch,
> HDFS-12997.003.patch
>
>
> Move logging to slf4j in BlockPoolSliceStorage and Storage classes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
