[
https://issues.apache.org/jira/browse/HDFS-12997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16340594#comment-16340594
]
Akira Ajisaka commented on HDFS-12997:
--------------------------------------
Thanks! I'm +1 if the following comments are addressed.
1. {{#toString}} method call should be removed from the arguments of logging
functions to avoid redundant toString method calls by lazy evaluation. For
example, in Storage.java line 901:
{code:java}LOG.error("Unable to acquire file lock on path {}",
lockF.toString());{code}
{{lockF.toString()}} can be replaced with {{LockF}}. Similar issues exist in
DataStorage.java line 672 and NNStorage.java line 1156.
2. DataStorage.java line 1238: Missing period in the end of warn message.
> Move logging to slf4j in BlockPoolSliceStorage and Storage
> -----------------------------------------------------------
>
> Key: HDFS-12997
> URL: https://issues.apache.org/jira/browse/HDFS-12997
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Ajay Kumar
> Assignee: Ajay Kumar
> Priority: Major
> Attachments: HDFS-12997.001.patch, HDFS-12997.002.patch,
> HDFS-12997.003.patch, HDFS-12997.004.patch
>
>
> Move logging to slf4j in BlockPoolSliceStorage and Storage classes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
