[
https://issues.apache.org/jira/browse/HDFS-13044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16340632#comment-16340632
]
Yiqun Lin commented on HDFS-13044:
----------------------------------
Almost looks good to me and your comment makes sense to me. Only some minor
comments relevant to the safemode settings:
*DFSConfigKeys.java*
line1240. Would you set {{DFS_ROUTER_CACHE_TIME_TO_LIVE_MS_DEFAULT * 3}} as
the default value? Seems this haven't been addressed.
*RouterSafemodeService.java*
line84 and line132: Would you print the time with {{MILLISECONDS}} format? The
potential problem of accurate loosing.
line101: Can you update the description of setting
{{dfs.federation.router.cache.ttl}} and change default value to {{1m}}? As I
see you have made it supporting time unit suffixes.
Others looks good to me.
> RBF: Add a safe mode for the Router
> -----------------------------------
>
> Key: HDFS-13044
> URL: https://issues.apache.org/jira/browse/HDFS-13044
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Íñigo Goiri
> Assignee: Íñigo Goiri
> Priority: Major
> Attachments: HDFS-13004.000.patch, HDFS-13044.001.patch,
> HDFS-13044.002.patch, HDFS-13044.003.patch
>
>
> When a Router cannot communicate with the State Store, it should enter into a
> safe mode that disallows certain operations.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
