[
https://issues.apache.org/jira/browse/HDFS-13168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16368685#comment-16368685
]
Íñigo Goiri edited comment on HDFS-13168 at 2/18/18 10:02 PM:
--------------------------------------------------------------
[~belugabehr], do you have any approximate performance improvements after using
{{ArrayDequeue}}?
I would go for it anyway but just for completeness.
A minor comment on [^HDFS-13168.1.patch], we could use the implicit type and
do {{new ArrayDeque<>();}}.
The failed unit tests seem unrelated to me.
The related test would be {{TestCheckpoint}} and it seems to
[pass|https://builds.apache.org/job/PreCommit-HDFS-Build/23114/testReport/org.apache.hadoop.hdfs.server.namenode/TestCheckpoint/];
not sure it tests much though.
was (Author: elgoiri):
[~belugabehr], do you have any approximate performance improvements after using
{{ArrayDequeue}}?
I would go for it anyway but just for completeness.
A minor comment on [^HDFS-13168.1.patch], we could use the implicit type and
do {{new ArrayDeque<>();}}.
The unit tests seem unrelated to me.
The related test would be {{TestCheckpoint}} and it seems to
[pass|https://builds.apache.org/job/PreCommit-HDFS-Build/23114/testReport/org.apache.hadoop.hdfs.server.namenode/TestCheckpoint/];
not sure it tests much though.
> XmlImageVisitor - Prefer Array over LinkedList
> ----------------------------------------------
>
> Key: HDFS-13168
> URL: https://issues.apache.org/jira/browse/HDFS-13168
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs
> Affects Versions: 3.0.0
> Reporter: BELUGA BEHR
> Priority: Minor
> Attachments: HDFS-13168.1.patch
>
>
> {{ArrayDeque}}
> {quote}This class is likely to be faster than Stack when used as a stack, and
> faster than LinkedList when used as a queue.{quote}
> .. not to mention less memory fragmentation (single backing array v.s. many
> ArrayList nodes).
> https://docs.oracle.com/javase/8/docs/api/java/util/ArrayDeque.html
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
