[ https://issues.apache.org/jira/browse/HDFS-13168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16370367#comment-16370367 ]
Íñigo Goiri edited comment on HDFS-13168 at 2/20/18 6:02 PM: ------------------------------------------------------------- {{StringBuilder}} is more optimal but I'm not sure how does + in {{String}} is implemented. Anyway, just philosophical at this point, it should be good either way. I'm committing [^HDFS-13168.2.patch] to {{trunk}}; [~belugabehr], for the commit message do I use your name capitalized as it is here or do you prefer some other spelling? was (Author: elgoiri): {{StringBuilder}} is more optimal but I'm not sure how does + in {{String}} is implemented. Anyway, just philosophical at this point, it should be good either way. I'm committing [^HDFS-13168.2.patch] to {{trunk}}; [~belugabehr], for the commit message do I use for your name capitalized as it is here or do you prefer some other spelling? > XmlImageVisitor - Prefer Array over LinkedList > ---------------------------------------------- > > Key: HDFS-13168 > URL: https://issues.apache.org/jira/browse/HDFS-13168 > Project: Hadoop HDFS > Issue Type: Improvement > Components: hdfs > Affects Versions: 3.0.0 > Reporter: BELUGA BEHR > Assignee: BELUGA BEHR > Priority: Minor > Attachments: HDFS-13168.1.patch, HDFS-13168.2.patch > > > {{ArrayDeque}} > {quote}This class is likely to be faster than Stack when used as a stack, and > faster than LinkedList when used as a queue.{quote} > .. not to mention less memory fragmentation (single backing array v.s. many > ArrayList nodes). > https://docs.oracle.com/javase/8/docs/api/java/util/ArrayDeque.html -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org