[
https://issues.apache.org/jira/browse/HDFS-13193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16377735#comment-16377735
]
Íñigo Goiri commented on HDFS-13193:
------------------------------------
Thanks [~belugabehr], let's do this switch to Logger in a separate JIRA.
The only controversial change would be switching to {{HashMultiset}}.
It looks like this should be covered by the unit tests already.
Can you double check?
If so, I'd commit this.
> Various Improvements for BlockTokenSecretManager.java
> -----------------------------------------------------
>
> Key: HDFS-13193
> URL: https://issues.apache.org/jira/browse/HDFS-13193
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs
> Affects Versions: 3.0.0
> Reporter: BELUGA BEHR
> Assignee: BELUGA BEHR
> Priority: Trivial
> Attachments: HDFS-13193.1.patch
>
>
> Various improvements for class
> {{org.apache.hadoop.hdfs.security.token.block.BlockTokenSecretManager.java}}
> # Remove superfluous {{toString}} calls
> # Fix some checkstyle warnings
> # Re-implement method with O(N^2) with HashMultiSet - also improves
> readability
> # Increase code re-use with Apache Commons Library
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
