[ 
https://issues.apache.org/jira/browse/HDFS-13193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16378081#comment-16378081
 ] 

BELUGA BEHR commented on HDFS-13193:
------------------------------------

Thanks [~elgoiri] !  Yes, there are unit tests, I have ran them manually 
several times locally.

https://github.com/apache/hadoop/blob/fc7ec80d85a751b2b2b261a2b97ec38c7b58f1df/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestBlockStoragePolicy.java#L1410

> Various Improvements for BlockTokenSecretManager.java
> -----------------------------------------------------
>
>                 Key: HDFS-13193
>                 URL: https://issues.apache.org/jira/browse/HDFS-13193
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: hdfs
>    Affects Versions: 3.0.0
>            Reporter: BELUGA BEHR
>            Assignee: BELUGA BEHR
>            Priority: Trivial
>         Attachments: HDFS-13193.1.patch
>
>
> Various improvements for class 
> {{org.apache.hadoop.hdfs.security.token.block.BlockTokenSecretManager.java}}
> # Remove superfluous {{toString}} calls
> # Fix some checkstyle warnings
> # Re-implement method with O(N^2) with HashMultiSet - also improves 
> readability
> # Increase code re-use with Apache Commons Library



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to