Xiaoyu Yao commented on HDFS-13148:

Thanks [~hanishakoneru] for improving test coverage on this.  It looks good to 
me overall, just few minor issues:

1. Line 128, 153-158: this is not needed. DFS has logic to ask the NN for its 
default KMS uri.  

2. NIT: createZones can be renamed to reflect the fact that it creates dirs on 
two namespaces.
3. You can use FileContext class to simplify the test prep which is easier than 
the FileSystemTestWrapper. Ex, for zone1, you can use the follow without 
getFQP() helper function.

    URI uri = cluster.getURI(1);
    fc = FileContext.getFileContext(uri, conf);
    fc.mkdir(fc.makeQualified(new Path(zones[1])), FileContext.DEFAULT_PERM, 

4. Can you clear the checkstyle warnings?

> Unit test for EZ with KMS and Federation
> ----------------------------------------
>                 Key: HDFS-13148
>                 URL: https://issues.apache.org/jira/browse/HDFS-13148
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: test
>            Reporter: Hanisha Koneru
>            Assignee: Hanisha Koneru
>            Priority: Major
>         Attachments: HDFS-13148.001.patch
> It would be good to have some unit tests for testing KMS and EZ on a 
> federated cluster. We can start with basic EZ operations. For example, create 
> EZs on two namespaces with different keys using one KMS.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to