[
https://issues.apache.org/jira/browse/HDFS-13148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16392091#comment-16392091
]
Hanisha Koneru commented on HDFS-13148:
---------------------------------------
Hi [~shahrs87], thanks for the review.
If we make {{TestEncryptionZonesWithKMSandFederation}} extend
{{TestEncryptionZonesWithKMS}} then the former would run all the test cases in
the later with its initial {{setup}}. This would fail all the tests in
{{TestEncryptionZonesWithKMS}} run against the setup of
{{TestEncryptionZonesWithKMSandFederation}}. To get over this, we would have to
modify all the test cases in {{TestEncryptionZonesWithKMS}} and
{{TestEncryptionZones}} to work with the federated configuration setup. For
example, instead of using variable {{dfsAdmin}} in
{{TestEncryptionZonesWithKMS}}, we would have to change it to \{{dsfAdmin[0]}}
to match the federated setup.
I think it would just complicate all the three Tests by doing this. We could
instead have a \{{TestEncryptionZonesBaseTest}} class and make all the other
Tests extend this class. Or we could just keep the non-federated Tests and
federated Tests separate (as is in patch v03). Please let me know your thoughts.
> Unit test for EZ with KMS and Federation
> ----------------------------------------
>
> Key: HDFS-13148
> URL: https://issues.apache.org/jira/browse/HDFS-13148
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: test
> Reporter: Hanisha Koneru
> Assignee: Hanisha Koneru
> Priority: Major
> Attachments: HDFS-13148.001.patch, HDFS-13148.002.patch,
> HDFS-13148.003.patch
>
>
> It would be good to have some unit tests for testing KMS and EZ on a
> federated cluster. We can start with basic EZ operations. For example, create
> EZs on two namespaces with different keys using one KMS.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
