[
https://issues.apache.org/jira/browse/HDFS-1900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13053507#comment-13053507
]
Aaron T. Myers commented on HDFS-1900:
--------------------------------------
Hey Abel, thanks a lot for the patch. It looks pretty good to me, but lets see
what the QA bot has to say.
One question - since, this patch changes the value of
{{FsConfig.FS_BLOCK_SIZE_KEY}}, did you check if that is referenced anywhere in
the Common project? If so, where? And did you try running the common unit tests
with this patch as well? Since this is an HDFS JIRA, the QA bot will only run
the HDFS tests, not the common ones.
> Use the block size key defined by common
> -----------------------------------------
>
> Key: HDFS-1900
> URL: https://issues.apache.org/jira/browse/HDFS-1900
> Project: Hadoop HDFS
> Issue Type: Improvement
> Affects Versions: 0.21.1
> Reporter: Eli Collins
> Assignee: Abel Perez
> Labels: newbie
> Fix For: 0.22.0
>
> Attachments: HDFS-1900.txt
>
>
> HADOOP-4952 added a dfs.block.size key to common configuration, defined in
> o.a.h.fs.FsConfig. This conflicts with the original HDFS block size key of
> the same name, which is now deprecated in favor of dfs.blocksize. It doesn't
> make sense to have two different keys for the block size (ie they can
> disagree). Why doesn't HDFS just use the key defined in common?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
