[
https://issues.apache.org/jira/browse/HDFS-12773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16395670#comment-16395670
]
Wei Yan commented on HDFS-12773:
--------------------------------
Thanks for the patch, [~elgoiri] .
Some minors on [^HDFS-12773.003.patch].
In StateStoreFileBaseImpl.java:
* The javadoc "implementation based on a local file" may need to be updated.
* The "return Time.now() - time > OLD_TMP_RECORD_MS;" in isOldTempRecord(), we
should use monotonicNow()?
* The StringBuffer can be replaced with StringBuilder in getPathForClass()
function.
In StateStoreFileImpl.java:
* For the config field FEDERATION_STORE_FILE_DIRECTORY, better move to
DFSConfigKeys?
* In getRootDir() function, if FEDERATION_STORE_FILE_DIRECTORY is not
configured, it would be better to print out a warning message to print out the
temp location.
> RBF: Improve State Store FS implementation
> ------------------------------------------
>
> Key: HDFS-12773
> URL: https://issues.apache.org/jira/browse/HDFS-12773
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Íñigo Goiri
> Assignee: Íñigo Goiri
> Priority: Major
> Attachments: HDFS-12773.000.patch, HDFS-12773.001.patch,
> HDFS-12773.002.patch, HDFS-12773.003.patch
>
>
> HDFS-10630 introduced a filesystem implementation of the State Store for unit
> tests. However, this implementation doesn't handle multiple writers
> concurrently.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
