[
https://issues.apache.org/jira/browse/HDFS-1321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13054168#comment-13054168
]
Aaron T. Myers commented on HDFS-1321:
--------------------------------------
Hey Jim, patch looks pretty good. Just a few small nits:
# The method to check the configs is called "VERIFYConfigurationSettings"
whereas the test is called "TestConfigurationVALIDATIONS". I think these should
be consistent, and I prefer the word "validate" in this context.
# No need for the StringBuilder in the case of this error - just break up the
message onto a few lines, e.g.:
\\
{quote}
"This is an " +
"error message.";
{quote}\\
# Rather than "HttpServerAddress Port" and "RPC Server Address Port" in the
error message, I'd recommend using the actual config keys, which are defined in
the {{DFSConfigKeys}} class.
# In the test, I'd recommend catching IOException explicitly, and maybe even
verifying the contents of the message string a little bit. We wouldn't want
this test to pass if a {{NullPointerException}} or an unrelated {{IOException}}
were thrown.
# The indentation is off throughout the patch. The Hadoop code base uses
2-space indentation, no tabs.
> If service port and main port are the same, there is no clear log message
> explaining the issue.
> -----------------------------------------------------------------------------------------------
>
> Key: HDFS-1321
> URL: https://issues.apache.org/jira/browse/HDFS-1321
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.23.0
> Reporter: gary murry
> Assignee: Jim Plush
> Priority: Minor
> Labels: newbie
> Fix For: 0.23.0
>
> Attachments: HDFS-1321-take2.txt, HDFS-1321.patch
>
>
> With the introduction of a service port to the namenode, there is now a
> chance for user error to set the two port equal. This will cause the
> namenode to fail to start up. It would be nice if there was a log message
> explaining the port clash. Or just treat things as if the service port was
> not specified.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
