[
https://issues.apache.org/jira/browse/HDFS-1321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13054711#comment-13054711
]
Aaron T. Myers commented on HDFS-1321:
--------------------------------------
Hey Jim, latest patch is almost there. Two tiny nits:
# I should've been more clear, but I think the error message should include the
*values* of those config options. i.e. I think the error message should end up
including "dfs.namenode.http-address" and "dfs.namenode.rpc-address" since
those are what are actually put in the config files. Users won't know what
{{DFS_NAMENODE_HTTP_ADDRESS_KEY}} and {{DFS_NAMENODE_RPC_ADDRESS_KEY}} mean.
# In {{testThatDifferentRPCandHttpPortsAreOK}}, there's no need to catch the
exception and explicitly call {{Assert.fail(...)}}. If an exception gets thrown
by a test method, that will indicate failure to the testing framework
automatically.
+1 after these issues are addressed.
> If service port and main port are the same, there is no clear log message
> explaining the issue.
> -----------------------------------------------------------------------------------------------
>
> Key: HDFS-1321
> URL: https://issues.apache.org/jira/browse/HDFS-1321
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.23.0
> Reporter: gary murry
> Assignee: Jim Plush
> Priority: Minor
> Labels: newbie
> Fix For: 0.23.0
>
> Attachments: HDFS-1321-take2.txt, HDFS-1321-take3.txt, HDFS-1321.patch
>
>
> With the introduction of a service port to the namenode, there is now a
> chance for user error to set the two port equal. This will cause the
> namenode to fail to start up. It would be nice if there was a log message
> explaining the port clash. Or just treat things as if the service port was
> not specified.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
