[ 
https://issues.apache.org/jira/browse/HDFS-2077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13054171#comment-13054171
 ] 

Todd Lipcon commented on HDFS-2077:
-----------------------------------

I don't think getCanonicalPath is a good idea.. the issue is that it will call 
stat and readlink on the path heirarchy to find the canonical path. Given that 
this function is called after an IOE, it's likely that those calls would 
actually fail, and then the error wouldn't be reported correctly.

Since we don't canonicalize paths anywhere, both the storage dir root and the 
files within should start with the same prefix, regardless of whether there is 
a symlink along the path.

Sound good?

> 1073: address checkpoint upload when one of the storage dirs is failed
> ----------------------------------------------------------------------
>
>                 Key: HDFS-2077
>                 URL: https://issues.apache.org/jira/browse/HDFS-2077
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: name-node
>    Affects Versions: Edit log branch (HDFS-1073)
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: Edit log branch (HDFS-1073)
>
>         Attachments: hdfs-2077.txt, hdfs-2077.txt
>
>
> This JIRA addresses the following case:
> - NN is running with 2 storage dirs
> - 1 of the dirs fails
> - 2NN makes a checkpoint
> Currently, if GetImageServlet fails to open _any_ of the local files to 
> receive a checkpoint, it will fail the entire checkpoint upload process. 
> Instead, it should continue to receive checkpoints in the non-failed 
> directories.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to