[
https://issues.apache.org/jira/browse/HDFS-13215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404141#comment-16404141
]
Íñigo Goiri commented on HDFS-13215:
------------------------------------
Thanks [~ywskycn] for [^HDFS-13215.007.patch].
I would also move the RBF documentation to the new package.
I'm not sure we should have {{hdfs-rbf-default.xml}} in {{hadoop-hdfs}}, I
think it should go to {{hadoop-hdfs-rbf}}.
Then {{hdfs-rbf-default.xml}} should not point to {{hdfs-site.xml}}, right?
Regarding the unit tests, the tweak with hdfs-site.xml fixed most of the
issues. Now I get:
{code}
[ERROR] Errors:
[ERROR] TestRouterAdminCLI.testCreateInvalidEntry:444 » NullPointerException
[ERROR] TestRouterRpc.testErasureCoding:985 » Remote
org.apache.hadoop.ipc.RemoteException(java.lang.NullPointerException
[ERROR] TestRouterRpcMultiDestination>TestRouterRpc.testErasureCoding:985 »
Remote org.apache.hadoop.ipc.RemoteException(java.lang.NullPointerException
{code}
The testErasureCoding comes from:
{code}
[ERROR]
testErasureCoding(org.apache.hadoop.hdfs.server.federation.router.TestRouterRpc)
Time elapsed: 0.754 s <<< ERROR!
org.apache.hadoop.ipc.RemoteException(org.apache.hadoop.ipc.RemoteException):
org.apache.hadoop.ipc.RemoteException(java.lang.NullPointerException):
java.lang.NullPointerException
at
org.apache.hadoop.hdfs.server.namenode.FSEditLogOp$AddErasureCodingPolicyOp.toString(FSEditLogOp.java:4482)
at java.lang.String.valueOf(String.java:2994)
at java.lang.StringBuilder.append(StringBuilder.java:131)
at
org.apache.hadoop.hdfs.server.namenode.FSEditLogAsync$RpcEdit.toString(FSEditLogAsync.java:319)
at java.lang.String.valueOf(String.java:2994)
at java.lang.StringBuilder.append(StringBuilder.java:131)
at
org.apache.hadoop.hdfs.server.namenode.FSEditLogAsync.logSync(FSEditLogAsync.java:128)
at
org.apache.hadoop.hdfs.server.namenode.FSNamesystem.addErasureCodingPolicies(FSNamesystem.java:7470)
at
org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer.addErasureCodingPolicies(NameNodeRpcServer.java:2418)
at
org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolServerSideTranslatorPB.addErasureCodingPolicies(ClientNamenodeProtocolServerSideTranslatorPB.java:1773)
at
org.apache.hadoop.ipc.ProtobufRpcEngine$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine.java:523)
{code}
This test runs fine in {{trunk}}.
The one for the CLI:
{code}
[ERROR]
testCreateInvalidEntry(org.apache.hadoop.hdfs.server.federation.router.TestRouterAdminCLI)
Time elapsed: 0.008 s <<< ERROR!
java.lang.NullPointerException
at
org.apache.hadoop.util.GenericOptionsParser.preProcessForWindows(GenericOptionsParser.java:529)
at
org.apache.hadoop.util.GenericOptionsParser.parseGeneralOptions(GenericOptionsParser.java:568)
at
org.apache.hadoop.util.GenericOptionsParser.<init>(GenericOptionsParser.java:174)
at
org.apache.hadoop.util.GenericOptionsParser.<init>(GenericOptionsParser.java:156)
at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:90)
at
org.apache.hadoop.hdfs.server.federation.router.TestRouterAdminCLI.testCreateInvalidEntry(TestRouterAdminCLI.java:444)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
{code}
However, this also fails on trunk for me so we can leave this one.
> RBF: Move Router to its own module
> ----------------------------------
>
> Key: HDFS-13215
> URL: https://issues.apache.org/jira/browse/HDFS-13215
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Íñigo Goiri
> Assignee: Wei Yan
> Priority: Major
> Attachments: HDFS-13215.000.patch, HDFS-13215.001.patch,
> HDFS-13215.002.patch, HDFS-13215.003.patch, HDFS-13215.004.patch,
> HDFS-13215.005.patch, HDFS-13215.006.patch, HDFS-13215.007.patch
>
>
> We are splitting the HDFS client code base and potentially Router-based
> Federation is also independent enough to be in its own package.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
