[ 
https://issues.apache.org/jira/browse/HDFS-13364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16420312#comment-16420312
 ] 

Yiqun Lin commented on HDFS-13364:
----------------------------------

Some initial comments (haven't fully reviewed):
 * {{NamenodeProto}} can implement {{NamenodeProtocol}}.
 * The tests for {{getTransactionID}} and {{getMostRecentCheckpointTxId}} calls 
were not added. Would you add this in {{TestRouterRPC}} as well?
 * For the {{ClientProtocol}} Implementation, we can also create one module 
like {{NamenodeProto}} (Even though this one is not related with this patch, 
but looks like we can refactor this as well).

> RBF: Support NamenodeProtocol in the Router
> -------------------------------------------
>
>                 Key: HDFS-13364
>                 URL: https://issues.apache.org/jira/browse/HDFS-13364
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Íñigo Goiri
>            Assignee: Íñigo Goiri
>            Priority: Major
>         Attachments: HDFS-13364.000.patch, HDFS-13364.001.patch, 
> HDFS-13364.002.patch, HDFS-13364.003.patch
>
>
> The Router should support the NamenodeProtocol to get blocks, versions, etc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to