[ https://issues.apache.org/jira/browse/HDFS-13364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16420793#comment-16420793 ]
Íñigo Goiri commented on HDFS-13364: ------------------------------------ [~linyiqun], thanks for the comments. * I renamed NamenodeProto to RouterNamenodeProtocol and made it implement NamenodeProtocol; this should keep compatibility easy to maintain. * I added tests for the missing methods. * I wished we had multiple inheritance and this could be split in modules cleanly without having to call everything twice (maybe we could leverage reflection). Anyway, yes, it would be a good idea to split ClientProtocol into a RouterClientProtocol module. I would create a separate JIRA for that. > RBF: Support NamenodeProtocol in the Router > ------------------------------------------- > > Key: HDFS-13364 > URL: https://issues.apache.org/jira/browse/HDFS-13364 > Project: Hadoop HDFS > Issue Type: Sub-task > Reporter: Íñigo Goiri > Assignee: Íñigo Goiri > Priority: Major > Attachments: HDFS-13364.000.patch, HDFS-13364.001.patch, > HDFS-13364.002.patch, HDFS-13364.003.patch, HDFS-13365.004.patch > > > The Router should support the NamenodeProtocol to get blocks, versions, etc. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org