[
https://issues.apache.org/jira/browse/HDFS-13331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16421037#comment-16421037
]
Erik Krogen commented on HDFS-13331:
------------------------------------
That seems reasonable to me, [~zero45] I will leave it up to you if you want to
address here or in a follow-up. My last comments on the patch:
* For {{testClientSendsGreaterState()}}, instead of {{@Ignored}}, can we use a
log capture to verify that the correct statement is logged? This still verifies
the correct code path was taken.
* style nit in {{Server}}:
{code}
if(alignmentContext != null) {
alignmentContext.receiveRequestState(header);
}
{code}
There should be a space between if and the parenthesis?
* re: the above code, I don't think {{checkRpcHeaders()}} is the right place
for it. The method name implies it is only doing a check, not any processing.
It seems that {{processRpcRequest()}} is a better place, since this is
processing the request and taking action on it.
> Add lastSeenStateId to RpcRequestHeader.
> ----------------------------------------
>
> Key: HDFS-13331
> URL: https://issues.apache.org/jira/browse/HDFS-13331
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: HDFS-12943
> Reporter: Plamen Jeliazkov
> Assignee: Plamen Jeliazkov
> Priority: Major
> Attachments: HDFS-13331-HDFS-12943.002.patch,
> HDFS-13331-HDFS-12943.003..patch, HDFS-13331.trunk.001.patch,
> HDFS_13331.trunk.000.patch
>
>
> HDFS-12977 added a stateId into the RpcResponseHeader which is returned by
> NameNode and stored by DFSClient.
> This JIRA is to followup on that work and have the DFSClient send their
> stored "lastSeenStateId" in the RpcRequestHeader so that ObserverNodes can
> then compare with their own and act accordingly.
> This JIRA work focuses on just the part of making DFSClient send their state
> through RpcRequestHeader.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
