[
https://issues.apache.org/jira/browse/HDFS-13350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16422878#comment-16422878
]
Ajay Kumar commented on HDFS-13350:
-----------------------------------
[~eddyxu] thanks for working on this. In addition to [~xiaochen]'s comments i
have few suggestions:
* Shall we make new function \{{BlockIdManager#isStripedBlock}} public as this
may be utilized outside default package
* We can prevent innocuous use of \{{isStripedBlockID}} by making it private.
* Typo in CorruptReplicasMap L209
> Negative legacy block ID will confuse Erasure Coding to be considered as
> striped block
> --------------------------------------------------------------------------------------
>
> Key: HDFS-13350
> URL: https://issues.apache.org/jira/browse/HDFS-13350
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: erasure-coding
> Affects Versions: 3.0.1
> Reporter: Lei (Eddy) Xu
> Assignee: Lei (Eddy) Xu
> Priority: Major
> Attachments: HDFS-13350.00.patch
>
>
> HDFS-4645 has changed HDFS block ID from randomly generated to sequential
> positive IDs. And later on, HDFS EC was built on the assumption that normal
> 3x replica block IDs are positive, so EC re-use negative IDs as striped
> blocks.
> However, there are legacy block IDs can be negative in the system, we should
> not use hardcode method to check whether a block is stripe or not:
> {code}
> public static boolean isStripedBlockID(long id) {
> return BlockType.fromBlockId(id) == STRIPED;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
