[ https://issues.apache.org/jira/browse/HDFS-13350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16427297#comment-16427297 ]
Hudson commented on HDFS-13350: ------------------------------- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13928 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/13928/]) HDFS-13350. Negative legacy block ID will confuse Erasure Coding to be (lei: rev d737bf99d44ce34cd01baad716d23df269267c95) * (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java * (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockIdManager.java * (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManagerSafeMode.java * (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/CorruptReplicasMap.java * (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/InvalidateBlocks.java * (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestCorruptReplicaInfo.java * (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestBlockManager.java * (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlocksMap.java > Negative legacy block ID will confuse Erasure Coding to be considered as > striped block > -------------------------------------------------------------------------------------- > > Key: HDFS-13350 > URL: https://issues.apache.org/jira/browse/HDFS-13350 > Project: Hadoop HDFS > Issue Type: Bug > Components: erasure-coding > Affects Versions: 3.0.1 > Reporter: Lei (Eddy) Xu > Assignee: Lei (Eddy) Xu > Priority: Major > Fix For: 3.2.0, 3.1.1, 3.0.3 > > Attachments: HDFS-13350.00.patch, HDFS-13350.01.patch, > HDFS-13350.02.patch > > > HDFS-4645 has changed HDFS block ID from randomly generated to sequential > positive IDs. And later on, HDFS EC was built on the assumption that normal > 3x replica block IDs are positive, so EC re-use negative IDs as striped > blocks. > However, there are legacy block IDs can be negative in the system, we should > not use hardcode method to check whether a block is stripe or not: > {code} > public static boolean isStripedBlockID(long id) { > return BlockType.fromBlockId(id) == STRIPED; > } > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org