[ https://issues.apache.org/jira/browse/HDFS-13326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16426245#comment-16426245 ]
Íñigo Goiri edited comment on HDFS-13326 at 4/4/18 10:10 PM: ------------------------------------------------------------- Thanks [~gangli2384], as a general comment, I would prefer to keep {{RemoteLocation}} as final. We could just create a copy of the entry; same for the MountTable, no need to update as we cna just create a new one and invalidate. I think this is safer for invalidation, etc. was (Author: elgoiri): Thanks [~gangli2384], as a general comment, I would prefer to keep {{RemoteLocation}} as final. We could just create a copy of the entry. > RBF: Improve the interfaces to modify and view mount tables > ----------------------------------------------------------- > > Key: HDFS-13326 > URL: https://issues.apache.org/jira/browse/HDFS-13326 > Project: Hadoop HDFS > Issue Type: Sub-task > Reporter: Wei Yan > Assignee: Gang Li > Priority: Minor > Attachments: HDFS-13326.000.patch > > > 1. From DFSRouterAdmin cmd, currently the update logic is implemented inside > add operation, where it has some limitation (e.g. cannot update "readonly" or > removing a destination). Given the RPC alreadys separate add and update > operations, it would be better to do the same in cmd level. > 2. Currently in the MountTable tab, the "readonly" field always show empty, > no matter whether the mount entry is readonly or not. From the code > perspective, it tries to show: > {code:java} > <td class="dfshealth-node-icon dfshealth-mount-read-only-{readonly}"/>{code} > The federationhealth.html will load hadoop.css, however the hadoop.css > doesn't have classes with a prefix "dfshealth-mount-read-only". This could be > fixed in HDFS-13204. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org