[ https://issues.apache.org/jira/browse/HDFS-13330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16426340#comment-16426340 ]
Wei-Chiu Chuang commented on HDFS-13330: ---------------------------------------- Hi [~gabor.bota] thanks for the patch. Overall looks good with a little suggestion for further improvement. {code:java} for (int i = 0; i < 3; i++){ {code} It would be better to make the number 3 a static final variable. {code:java} // Teardown cache.close(); {code} You might want to consider using the try with resource statement to ensure it is closed properly. > ShortCircuitCache#fetchOrCreate never retries > --------------------------------------------- > > Key: HDFS-13330 > URL: https://issues.apache.org/jira/browse/HDFS-13330 > Project: Hadoop HDFS > Issue Type: Bug > Reporter: Wei-Chiu Chuang > Assignee: Gabor Bota > Priority: Major > Attachments: HDFS-13330.001.patch, HDFS-13330.002.patch, > HDFS-13330.004.patch > > > The follow do .. while(false) loop seems useless to me. The code intended to > retry but it never worked. Let's fix it. > {code:java:title=ShortCircuitCache#fetchOrCreate} > ShortCircuitReplicaInfo info = null; > do { > if (closed) { > LOG.trace("{}: can't fethchOrCreate {} because the cache is closed.", > this, key); > return null; > } > Waitable<ShortCircuitReplicaInfo> waitable = replicaInfoMap.get(key); > if (waitable != null) { > try { > info = fetch(key, waitable); > } catch (RetriableException e) { > LOG.debug("{}: retrying {}", this, e.getMessage()); > } > } > } while (false);{code} -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org