[
https://issues.apache.org/jira/browse/HDFS-13399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16428591#comment-16428591
]
Plamen Jeliazkov commented on HDFS-13399:
-----------------------------------------
Hey [~xkrogen], thanks for the prompt review. :)
*(1) We currently don't have a version of
NameNodeProxies#createProxy(Configuration, URI, Class<T>, AtomicBoolean) which
accepts an alignment context, should we add one?*
I saw that this method was only utilized by unit tests via {{NNConnector}},
{{DFSAdmin}}, and {{GetGroups}}. I decided not to modify it as it seems
{{DFSClients}} are not expressly utilizing this call for proxies. If you feel
otherwise though I would be glad to add it in my next patch.
*(2) Why is one getProxy() method removed from ProtobufRpcEngine?*
I was finding that that particular method was now unused and since it was not
an {{@Override}} from {{RpcEngine}} I assumed it was acceptable to delete. I
thought at the time that it became unused _due_ to the change in {{RpcEngine}}
but I see now that shouldn't have affected it. I'll happily add it back – less
deltas in the patch and retains expected public calls.
*(3) Why is IPFailoverProxyProvider passing null as its assignment context
instead of getAlignmentContext()?*
Ah, an unfortunate accident from overloading so many methods. Good catch. It
should be {{getAlignmentContext()}}.
> Make Client field AlignmentContext non-static.
> ----------------------------------------------
>
> Key: HDFS-13399
> URL: https://issues.apache.org/jira/browse/HDFS-13399
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: HDFS-12943
> Reporter: Plamen Jeliazkov
> Assignee: Plamen Jeliazkov
> Priority: Major
> Attachments: HDFS-13399-HDFS-12943.000.patch
>
>
> In HDFS-12977, DFSClient's constructor was altered to make use of a new
> static method in Client that allowed one to set an AlignmentContext. This
> work is to remove that static field and make each DFSClient pass it's
> AlignmentContext down to the proxy Call level.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
