[ 
https://issues.apache.org/jira/browse/HDFS-13403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16430805#comment-16430805
 ] 

James Clampffer commented on HDFS-13403:
----------------------------------------

Attached a patch.  Not a whole lot going on other than making uses of 
asio::io_service in arguments and member variables instances of 
shared_ptr<hdfs::IoService>.

Since this already touched a lot of files I cleaned up a few things as I went:
-Clear out includes in headers that weren't necessary.
-Pull a few method implementations out of header files.
-Rename the MutableBuffers typedef to MutableBuffer to avoid confusion with 
BufferSequences which aren't supported in the FileSystem API yet.


> libhdfs++: Use hdfs::IoService object rather than asio::io_service
> ------------------------------------------------------------------
>
>                 Key: HDFS-13403
>                 URL: https://issues.apache.org/jira/browse/HDFS-13403
>             Project: Hadoop HDFS
>          Issue Type: Task
>            Reporter: James Clampffer
>            Assignee: James Clampffer
>            Priority: Critical
>         Attachments: HDFS-13403.000.patch
>
>
> At the moment the hdfs::IoService is a simple wrapper over asio's io_service 
> object.  I'd like to make this smarter and have it do things like track which 
> tasks are queued, validate that dependencies of tasks exist, and monitor 
> ioservice throughput and contention.  In order to get there we need to use 
> have all components in the library to go through the hdfs::IoService rather 
> than directly interacting with the asio::io_service.  The only time the 
> asio::io_service should be used is when calling things like asio::async_write 
> that need an io_service&.  HDFS-11884 will be able get rid of those remaining 
> instances once this work is in place.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to